Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opam-0install-cudf: Add a raw diagnostics API for conflicts post-processing #44

Closed
wants to merge 2 commits into from

Conversation

kit-ty-kate
Copy link
Collaborator

@talex5 do you know if there would be any unused variants in the Raw_diagnostics module definition? (akin to the cases with the assert false)

@talex5
Copy link
Collaborator

talex5 commented Aug 10, 2022

In the non-cudf API, we have:

  module Diagnostics : sig
    include module type of Zeroinstall_solver.Diagnostics(Solver.Output)
  end

  val diagnostics_rolemap : diagnostics -> Diagnostics.t

Is there a reason to do it differently for cudf?

@kit-ty-kate
Copy link
Collaborator Author

the current interface does not export Solver but in any case this PR cleans up the data that are not going to be used (e.g. Context.t in role, some useless ints and cases such as ClassConflict, MissingCommand, …

In any case, in my opinion, exporting it this way makes it much cleaner and avoids back and forth between the definitions to actually understand how to use the data.

@talex5
Copy link
Collaborator

talex5 commented Aug 12, 2022

OK. The asserts look safe to me, given the cudf stuff doesn't use machine groups, class conflicts or commands.

@kit-ty-kate
Copy link
Collaborator Author

Moved to ocaml-opam/opam-0install-cudf#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants